branch-4.1: [fix](fe) Preserve operative slots when deep copying logical relations #63315#63709
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](fe) Preserve operative slots when deep copying logical relations #63315#63709github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
#63315) problem summary: When deep copying a `LogicalCatalogRelation`, `LogicalPlanDeepCopier#updateOperativeSlots` needs to remap the original relation's operative slots to the corresponding slots in the copied relation. Before this change, the search range was incorrectly limited by `oldOperativeSlots.size()` instead of the relation output size. If the operative slot was not located in the first `oldOperativeSlots.size()` output positions, the copier could not find the matching slot and the copied relation would lose that operative slot. For example, when a relation has multiple output slots but only one operative slot at index 1, the old logic only checked index 0 and failed to preserve the operative slot. Co-authored-by: yangtao555 <yangtao555@jd.com>
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63315